Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3094: Push notifications quit state solution #3125

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bahaaTuffaha
Copy link
Contributor

Short Description

At the moment, push notifications are not correctly handled if the app is in a quit state on android (and most likely on iOS, too). The app only opens on the last opened page. In theory, this might also be a development issue though.

Proposed Changes

  • Used setBackgroundMessageHandler instead of importFirebaseMessaging
  • I don't think it needs unsubing like it was from my searching over internet.
  • there was an error for jest about:
Invariant Violation: `new NativeEventEmitter()` requires a non-null argument. 

I solved it by jest.mock('react-native/Libraries/EventEmitter/NativeEventEmitter') according to here

Side Effects

  • I hope none

Testing

Resolved Issues

Fixes: #3094


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push notifications not correctly opened in quit state
1 participant