Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#81: Fix of AvoidUsingObjectMapperAsALocalVariable #83

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

smithros
Copy link
Collaborator

@smithros smithros commented Feb 8, 2022

Many thanks for your contribution, we truly appreciate it. We will appreciate it even more, if you make sure that you can say "YES" to each point in this short checklist:

  • You made a small amount of changes (less than 100 lines, less than 10 files)
  • You made changes related to only one bug (create separate PRs for separate problems)
  • You are ready to defend your changes (there will be a code review)
  • You don't touch what you don't understand
  • You ran the build locally and it passed

This article will help you understand what we are looking for: http://www.yegor256.com/2015/02/09/serious-code-reviewer.html

Thank you for your contribution!

@dgroup
Copy link
Owner

dgroup commented Feb 8, 2022

@rultor merge

@dgroup dgroup added this to the 0.1.0 milestone Feb 8, 2022
@dgroup dgroup added the bug Something isn't working label Feb 8, 2022
@rultor
Copy link
Collaborator

rultor commented Feb 8, 2022

@rultor merge

@dgroup OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit cc75770 into dgroup:master Feb 8, 2022
@rultor
Copy link
Collaborator

rultor commented Feb 8, 2022

@rultor merge

@dgroup Done! FYI, the full log is here (took me 3min)

@dgroup dgroup modified the milestone: 0.1.0 Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AvoidUsingObjectMapperAsALocalVariable should consider @PostConstruct annotation
3 participants