Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: miro (original, original-wordmark, plain, plain-wordmark) #1806

Closed
wants to merge 9 commits into from
Closed

new icon: miro (original, original-wordmark, plain, plain-wordmark) #1806

wants to merge 9 commits into from

Conversation

Gautam25Raj
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1786

Link to prove your SVG is correct and up-to-date.

https://miro.com/

@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 3, 2023
Panquesito7
Panquesito7 reviewed Jul 3, 2023
View reviewed changes
Gautam25Raj
Gautam25Raj commented Jul 4, 2023
View reviewed changes
Copy link
Contributor Author

@Gautam25Raj Gautam25Raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess now everything looks okay

@Gautam25Raj Gautam25Raj requested a review from Panquesito7 July 4, 2023 05:28
Panquesito7
Panquesito7 requested changes Jul 4, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this bug is still present. Please fix it.
If you need any help, let us know about it. 🙂

image

Gautam25Raj
Gautam25Raj commented Jul 4, 2023
View reviewed changes
Copy link
Contributor Author

@Gautam25Raj Gautam25Raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now they look perfectly fine.

miro-plain
miro-plain-workmark

@Gautam25Raj Gautam25Raj requested a review from Panquesito7 July 4, 2023 06:22
lunatic-fox
lunatic-fox requested changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This icon falls under Prototyping tools: Wiki.
I don't think this one follows the project scope, what do you think @Panquesito7?

@lunatic-fox lunatic-fox added the discussion Use this label for community discussions about changes/features/.. label Jul 4, 2023
@Panquesito7
Copy link
Member

It appears you're right about that. I think we'll have to close this sadly.

@Snailedlt
Copy link
Collaborator

@Panquesito7 @lunatic-fox
Miro is mainly used by software developers and UI/UX designers (I've used it extensively myself in professional settings).. The reason we need to discuss Prototyping tools is because a lot of them are too general purpose, but since this is mainly used by developers and designers I believe this tool fits the bill for devicon.

What do you guys think?

@Gautam25Raj
Copy link
Contributor Author

@Panquesito7 @lunatic-fox Miro is mainly used by software developers and UI/UX designers (I've used it extensively myself in professional settings).. The reason we need to discuss Prototyping tools is because a lot of them are too general purpose, but since this is mainly used by developers and designers I believe this tool fits the bill for devicon.

What do you guys think?

We already have Prototyping and designing tool like figma in Devicon and Miro itself is a Realtime Collaborative software used by many developers and designers like us to develop user flow, design and many other tasks.

@canaleal
Copy link
Member

Closing this ticket as it has been open for 1 year and 5 months. Feel free to reopen it if needed.

@canaleal canaleal closed this Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox

Assignees
No one assigned
Labels
discussion Use this label for community discussions about changes/features/.. feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gautam25Raj @Panquesito7 @Snailedlt @canaleal @lunatic-fox