Reland perf fix for nan inf check #7184
Open
+16
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelyahu
force-pushed
the
reland_perf_fix_for_nan_inf_check
branch
from
6f123cc to
2166ff4
Compare
tjruwase
reviewed
Mar 30, 2025
…edai#7171)" This reverts commit 1f70662. Signed-off-by: Nadav Elyahu <[email protected]>
Signed-off-by: Nadav Elyahu <[email protected]>
Signed-off-by: Nadav Elyahu <[email protected]>
nelyahu
force-pushed
the
reland_perf_fix_for_nan_inf_check
branch
from
889c90d to
cddef4c
Compare
tjruwase
approved these changes
Mar 31, 2025
|
@nelyahu - could you run the pre-commit formatter and then we can merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace previous usage with logical ops for nan/inf detect with torch.where