Pare down the C# example a little #1
Conversation
|
|
||
| ActivitySource ExampleWeatherServiceActivitySource = new("Example Weather Service"); | ||
| var exampleActivitySource = new ActivitySource("Example.WeatherService"); |
There was a problem hiding this comment.
Convention for activity source names is normally namespace-style.
|
|
||
| try |
There was a problem hiding this comment.
Catch block is redundant, since allowing the exception to escape Main() will also produce a nonzero exit code, and have the side-effect of printing some useful output to stderr.
| { | ||
| openTelemetryLoggerOptions.SetResourceBuilder( | ||
| ResourceBuilder.CreateEmpty() | ||
| .AddService(serviceName: builder.Environment.ApplicationName)); |
There was a problem hiding this comment.
Removed the example resource attributes; these are normally set through environment variables and other means (although adding them here is still valid).
|
|
||
| app.MapGet("/{postcode}", (string postcode) => | ||
| // Some important options to improve data quality | ||
| openTelemetryLoggerOptions.IncludeScopes = true; |
There was a problem hiding this comment.
Don't need IncludeFormattedMessage anymore, Seq will heuristically detect message templates.
| { | ||
| return 1; | ||
| } | ||
| using var activity = exampleActivitySource.StartActivity("Look up forecast for postcode {Postcode}"); |
There was a problem hiding this comment.
The suppressed warning at the top of the file is because we want to pass an activity name explicitly here.
|
much better! |
This proposes a couple of possible updates for the C# example. I'll comment them all inline, they're definitely not all necessary, let me know what you think! :-)