Updated Spark setup script #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage tests results430 tests ±0 382 ✅ ±0 5s ⏱️ ±0s For more details on these failures, see this check. Results for commit be2c45c. ± Comparison against base commit 6794006. ♻️ This comment has been updated with latest results. |
bishwajit-db
requested changes
Sep 3, 2024
sundarshankar89
pushed a commit
to sundarshankar89/remorph
that referenced
this pull request
Jan 2, 2025
1. Updated Spark setup script to check whether `spark gzip file` exists
1. Refactored the script to remove the warnings:
* `Double quote to prevent globbing and word splitting`
* `Use 'cd ... || exit' or 'cd ... || return' in case cd fails.`
* `Consider using 'grep -c' instead of 'grep|wc -l'.`
* `Usage: sleep seconds`, converted 2m to 120 seconds
1. Tested the following Scenarios:
1. Scenario: Extracted Spark folder is already present
Outcome: Directly starts the spark server using
`sbin/start-connect-server.sh`
1. Scenario: Extracted Spark folder **is not present**, and Zip file
(`spark-<VERSION>.tgz`) is present
Outcome: Extract the zip file and start the spark server
1. Scenario: Extracted Spark folder **is not present**, and Zip file
**is not present**
Outcome: Download, Extract and start the spark server
sundarshankar89
pushed a commit
to sundarshankar89/remorph
that referenced
this pull request
Jan 3, 2025
1. Updated Spark setup script to check whether `spark gzip file` exists
1. Refactored the script to remove the warnings:
* `Double quote to prevent globbing and word splitting`
* `Use 'cd ... || exit' or 'cd ... || return' in case cd fails.`
* `Consider using 'grep -c' instead of 'grep|wc -l'.`
* `Usage: sleep seconds`, converted 2m to 120 seconds
1. Tested the following Scenarios:
1. Scenario: Extracted Spark folder is already present
Outcome: Directly starts the spark server using
`sbin/start-connect-server.sh`
1. Scenario: Extracted Spark folder **is not present**, and Zip file
(`spark-<VERSION>.tgz`) is present
Outcome: Extract the zip file and start the spark server
1. Scenario: Extracted Spark folder **is not present**, and Zip file
**is not present**
Outcome: Download, Extract and start the spark server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Spark setup script to check whether
spark gzip fileexistsRefactored the script to remove the warnings:
Double quote to prevent globbing and word splittingUse 'cd ... || exit' or 'cd ... || return' in case cd fails.Consider using 'grep -c' instead of 'grep|wc -l'.Usage: sleep seconds, converted 2m to 120 secondsTested the following Scenarios:
Outcome: Directly starts the spark server using
sbin/start-connect-server.shspark-<VERSION>.tgz) is presentOutcome: Extract the zip file and start the spark server
Outcome: Download, Extract and start the spark server