Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitaiton & Clean Up. #30

Merged
merged 7 commits into from
Apr 30, 2022
Merged

Conversation

DiscoRiver
Copy link
Contributor

Some comment sanitation and code clean up for your good repo!

@Naman2706 Naman2706 requested a review from aman00323 April 20, 2022 06:27
@pratikbin
Copy link
Member

@aman00323 or @Naman2706 Any updates on this ?

@aman00323
Copy link
Contributor

@pratikbin Looks good can anyone test this locally @Naman2706, @pratikbin, @vyas-shyam

@DiscoRiver
Copy link
Contributor Author

DiscoRiver commented Apr 30, 2022

Following up to get this one closed out or merged.

@pratikbin pratikbin requested a review from shyamvyas5 April 30, 2022 17:47
@pratikbin pratikbin requested review from shyamvyas5 and pratikbin and removed request for aman00323 and shyamvyas5 April 30, 2022 18:38
@pratikbin
Copy link
Member

@DiscoRiver GitHub facing some issue in CI approvals, so I'll lint and scan code in local and will merge if everything goes fine

@pratikbin pratikbin merged commit 892ad6f into daftcreations:main Apr 30, 2022
@pratikbin
Copy link
Member

@DiscoRiver Thank you for contribution. Hope it help(s|d) you.

May the source be with you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants