Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return json from debug server if requested #245

Merged
merged 3 commits into from
Mar 23, 2025

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Mar 22, 2025

A small change to offer an option to return JSON from the debug server

Copy link

netlify bot commented Mar 22, 2025

Deploy Preview for dada-lang ready!

Name Link
🔨 Latest commit c8ca6ac
🔍 Latest deploy log https://app.netlify.com/sites/dada-lang/deploys/67dee8b3e160980008b5559b
😎 Deploy Preview https://deploy-preview-245--dada-lang.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nikomatsakis
Copy link
Member

@ciyer I did a bit of refactoring, see most recent commit

@nikomatsakis
Copy link
Member

Oh, wait.

@nikomatsakis
Copy link
Member

It doesn't want to let me push for some reason.

@nikomatsakis
Copy link
Member

Copy link
Member

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you're just dumping all the events in one shot. Seems fine, though I imagine we might later want to refine this to chunk the return value.

@nikomatsakis nikomatsakis added this pull request to the merge queue Mar 23, 2025
@nikomatsakis nikomatsakis removed this pull request from the merge queue due to a manual request Mar 23, 2025
@nikomatsakis nikomatsakis merged commit df87773 into dada-lang:main Mar 23, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants