-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Access Token Authorization + Screenshot Automation #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update API - Update ScreenshotsFeature Add new methods to update screenshots to CrowdinSDK Add ability to enter screenshot name when capture from floating button. Add message to logs with result of screenshot capturing: new or updated.
Add support for Screenshots and Real time updates features to work with new access token authorization.
# Conflicts: # Sources/CrowdinSDK/Features/ScreenshotFeature/ScreenshotUploader.swift # Sources/CrowdinSDK/Settings/SettingsView/SettingsView+UITableView.swift
SwiftLint found issues
Generated by 🚫 Danger Swift against 260f7c3 |
Added new method for screenshot update Review and update setup, installation and real-time-preview docs.
Update screenshot feature to screenshot uploader before adding screenshots. (Download mapping) Update crowdin mapping manager to support download completions. Adjust captureAndUpdateScreenshot method - add result parameter to completion. Update screenshots documentation to adjust captureAndUpdateScreenshot method update.
Remove test code to capture screenshot.
* Added separate subspec/package for tests with the ability to search localized strings onthe current screen. * Add new methods needed to upload screenshots from tests with screenshots image and controls information. * Adjust code to make ability to search localized strings in tests. * Setup simple UI test example for capturing 2 screenshots * Update SDK code to make work CrowdinSDK.startWithConfigSync and prepareSync(ScreenshotUploader) methods. * Adopt example project to work with tests(hide settings button in tests) * Update documentation.
andrii-bodnar
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the #301 PR.