Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove logic of path generation for content and mapping downloading #255

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

serhii-londar
Copy link
Collaborator

@serhii-londar serhii-londar commented Nov 24, 2023

Closes #239

@serhii-londar serhii-londar changed the title Remove logic of path generation for content and mapping downloading. refactor: Remove logic of path generation for content and mapping downloading. Nov 24, 2023
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (f66b2db) 60.53% compared to head (12a1a7c) 59.53%.
Report is 2 commits behind head on master.

Files Patch % Lines
...n/MappingDownloader/CrowdinMappingDownloader.swift 0.00% 7 Missing ⚠️
...ContentDeliveryAPI/CrowdinContentDeliveryAPI.swift 68.75% 5 Missing ⚠️
...I/ContentDeliveryAPI/Models/ManifestResponse.swift 40.00% 3 Missing ⚠️
...ders/Crowdin/ManifestManager/ManifestManager.swift 83.34% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
- Coverage   60.53%   59.53%   -0.99%     
==========================================
  Files         123      121       -2     
  Lines        4567     4420     -147     
==========================================
- Hits         2764     2631     -133     
+ Misses       1803     1789      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-bodnar andrii-bodnar changed the title refactor: Remove logic of path generation for content and mapping downloading. refactor: Remove logic of path generation for content and mapping downloading Dec 12, 2023
@andrii-bodnar andrii-bodnar merged commit 065715a into master Jan 8, 2024
@andrii-bodnar andrii-bodnar deleted the #273 branch January 8, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the distribution manifest content to fetch localization instead of building paths on the SDK side
2 participants