-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the tables dark theme issue for Headless Typedoc #5077
base: master
Are you sure you want to change the base?
Conversation
Pull Request ReportPR Title❌ Title should follow the conventional commit spec: Example: Live demo linksBundle Size
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should you also fix this for headless-react ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought I fixed this 🤔
#4963
In fact, I can't reproduce the bug on my machine...
If you do a hard refresh, does the issue go away on your browser @eguyon-coveo ?
(if you have a cached version of the CSS before my fix, it would explain why your table styling is messed up)
I don't think it's a cache issue because I ran it on incognito and got the same issue. When I load the page, the data-theme is set to "os" by default. The theme then changes based on the computer settings ![]() When I change it to "dark", your code works. I think it might related to cookies. I talked to @jsmith2-coveo about it and he could probably explain it better than me Screen.Recording.2025-03-14.at.5.10.24.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah my bad, TIL
Thanks Elouan
To see the problem we currently have, you can open an incognito window and go to https://docs.coveo.com/en/headless/latest/reference/index.html
You'll see that the table has a bad UI when in dark mode
This is because data-theme is set to "os" when we dont have the cookies selected.
The solution is to use --color-background as the background color