Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(atomic): fix flaky theming smoke tests #5072

Merged
merged 3 commits into from
Mar 14, 2025
Merged

chore(atomic): fix flaky theming smoke tests #5072

merged 3 commits into from
Mar 14, 2025

Conversation

fpbrault
Copy link
Contributor

Some of the theming smoke tests where failing due to source changes. Added a query so that the results are always the same (connect.coveo.com).

https://coveord.atlassian.net/browse/KIT-4052

Verified

This commit was signed with the committer’s verified signature.
fpbrault Felix Perron-Brault

Verified

This commit was signed with the committer’s verified signature.
fpbrault Felix Perron-Brault
fix test

Verified

This commit was signed with the committer’s verified signature.
fpbrault Felix Perron-Brault
@fpbrault fpbrault marked this pull request as ready for review March 13, 2025 21:34
@fpbrault fpbrault requested a review from a team as a code owner March 13, 2025 21:34
@fpbrault fpbrault enabled auto-merge March 13, 2025 21:36
Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 246.6 246.6 0
commerce 359.2 359.2 0
search 417.3 417.3 0
insight 408.5 408.5 0
recommendation 258 258 0
ssr 411.1 411.1 0
ssr-commerce 375.7 375.7 0

@fpbrault fpbrault added this pull request to the merge queue Mar 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 14, 2025
@louis-bompart louis-bompart added this pull request to the merge queue Mar 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 14, 2025
@louis-bompart louis-bompart merged commit 2c39a87 into master Mar 14, 2025
97 checks passed
@louis-bompart louis-bompart deleted the KIT-4052 branch March 14, 2025 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants