feat(atomic): localize tab name & label #5071
Draft
+53
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-bompart
requested review from
olamothe,
fpbrault,
fbeaudoincoveo and
alexprudhomme
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
|
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Adapt the `atomic-tab-manager.tsx` component to use the i18n library for localization of the `label` and `name` parameters. * Update the `label` and `name` properties to use `this.bindings.i18n.t` for localization. * Add a new test file `atomic-tab-manager.spec.tsx` to check if the `label` and `name` parameters are localized using `bindings.i18n.t`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/coveo/ui-kit?shareId=XXXX-XXXX-XXXX-XXXX).
louis-bompart
force-pushed
the
louis-bompart/localize-tab-label
branch
from
1700193 to
43c788b
Compare
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt the
atomic-tab-manager.tsxcomponent to use the i18n library for localization of thelabelandnameparameters.labelandnameproperties to usethis.bindings.i18n.tfor localization.atomic-tab-manager.spec.tsxto check if thelabelandnameparameters are localized usingbindings.i18n.t.For more details, open the Copilot Workspace session.