-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(headless commerce SSR): refactor remix sample to include search box in global header #5065
Open
fbeaudoincoveo
wants to merge
4
commits into
master
Choose a base branch
from
KIT-4048
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request ReportPR Title❌ Title should follow the conventional commit spec: Example: Live demo linksBundle Size
|
fbeaudoincoveo
commented
Mar 13, 2025
fbeaudoincoveo
commented
Mar 13, 2025
alexprudhomme
approved these changes
Mar 13, 2025
packages/samples/headless-commerce-ssr-remix/app/routes/search.tsx
Outdated
Show resolved
Hide resolved
packages/samples/headless-commerce-ssr-remix/lib/commerce-engine.server.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/KIT-4048
In summary:
I added a
Header
component, which accepts children.In the root
Layout
, we now check whether we're on the search page (by looking at the URL pathname). If we're NOT on the search page, we pass aStandaloneSearchBox
component wrapped in aStandaloneProvider
as a child to theHeader
.If we're on the search page, we instead pass a
SearchBox
component as a child for theHeader
, and we wrap theParameterManager
andHeader
components, as well as all children in aSearchProvider
. This means we can remove all of the logic from theSearch
page loader (and also remove theSearch
page's wrappingSearchProvider
).The fact that we're now doing more Headless-related logic in the root
Layout
made me realize that we could do some refactoring to simplify a few things.Instead of always setting the navigator context provider and updating the search token, I wrote a util to get the pre-updated definition.
I also wrote another util to get the base fetch static state configuration (because it's always basically the same).