-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(atomic): migrate atomic-commerce-interface to Lit #5017
Draft
fpbrault
wants to merge
5
commits into
KIT-4050
Choose a base branch
from
KIT-3932
base: KIT-4050
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,138
−853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
|
b29b61c
to
1b39b93
Compare
d585c51
to
e2ae1fe
Compare
2e49c87
to
21295bd
Compare
a8694ba
to
e6a270f
Compare
https://coveord.atlassian.net/browse/KIT-3932 use non-stencil getAssetPath https://coveord.atlassian.net/browse/KIT-3932 remove log https://coveord.atlassian.net/browse/KIT-3932 smaller styles https://coveord.atlassian.net/browse/KIT-3932 remove unused styles https://coveord.atlassian.net/browse/KIT-3932 add missing generated files https://coveord.atlassian.net/browse/KIT-3932 fix build https://coveord.atlassian.net/browse/KIT-3932 cleanup https://coveord.atlassian.net/browse/KIT-3932 other approach for loader https://coveord.atlassian.net/browse/KIT-3932 cleanup https://coveord.atlassian.net/browse/KIT-3932 create bindings decorator https://coveord.atlassian.net/browse/KIT-4005 fix bindings https://coveord.atlassian.net/browse/KIT-4005 add commerce page to angular sample https://coveord.atlassian.net/browse/KIT-3932 fix interface init https://coveord.atlassian.net/browse/KIT-3932 revert setup https://coveord.atlassian.net/browse/KIT-3932 revert loader change https://coveord.atlassian.net/browse/KIT-3932 restore coveoglobal for lit interface https://coveord.atlassian.net/browse/KIT-3932 fix init https://coveord.atlassian.net/browse/KIT-3932 fix story https://coveord.atlassian.net/browse/KIT-3932 fix missing global version https://coveord.atlassian.net/browse/KIT-3932 cleanup https://coveord.atlassian.net/browse/KIT-3932
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Component Name] Component Specification
📝 Requirements
The
[component-name]
component is designed to [brief description of the component's purpose].♿ Accessibility
⚡ Performance & Security (if applicable)
✅ Checklist
index.ts
andlazy-index.ts
files.https://coveord.atlassian.net/browse/KIT-[____]