fix(CodeEditor): format text only on valid input #4028
Merged
+12
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Currently, the
CodeEditor
uses the default formatting provided by the Monaco Editor. Forjson
language, the editor inherently relies onvscode-json-languageservice
, which does a best-effort formatting of the text regardless whether the JSON is valid or not.However, in the scenario where the JSON is invalid, we've observed UI issues caused by the formatting, where the mouse pointer is relocated to the end of the text:
13-46-51.mp4
Thus we want to disable the best-effort formatting. This is done by overriding the default formatter with a simple
JSON.stringify(JSON.parse(model.getValue()), null, tabSize)
, which will fail in invalid scenarios and thus does nothing.Potential Breaking Changes
None since change is behavioral.
Acceptance Criteria