Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct panic messages and enforce sealing check in SetStreamingManager (backport #23951) #24083

Open
wants to merge 5 commits into
base: release/v0.53.x
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 20, 2025

  • Updated panic messages in SetCMS and SetCheckTxHandler to correctly reflect function names.
  • Added a missing if app.sealed check in SetStreamingManager to prevent modifications after sealing.

Why?

  • Ensures panic messages match function names, making debugging more straightforward.
  • Aligns SetStreamingManager with the behavior of other setter methods that enforce sealing checks.

Author Checklist

I have...

  • included the correct type prefix in the PR title (fix)
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • Bug Fixes
    • Updated panic messages to accurately reflect method names when the BaseApp is sealed, ensuring clearer error notifications during unauthorized operations.

This is an automatic backport of pull request #23951 done by [Mergify](https://mergify.com).

…Manager (#23951)

(cherry picked from commit a9e7d5b)

# Conflicts:
#	CHANGELOG.md
#	baseapp/options.go
Copy link
Contributor Author

mergify bot commented Mar 20, 2025

Cherry-pick of a9e7d5b has failed:

On branch mergify/bp/release/v0.53.x/pr-23951
Your branch is up to date with 'origin/release/v0.53.x'.

You are currently cherry-picking commit a9e7d5b5a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md
	both modified:   baseapp/options.go

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested a review from a team as a code owner March 20, 2025 19:02
@mergify mergify bot added the conflicts label Mar 20, 2025
@technicallyty
Copy link
Contributor

hi @Pricstas, are you able to help cleanup this backport PR?

@Pricstas
Copy link
Contributor

Hey @technicallyty, I can resolve the conflicts and push the fixes if I have access to the branch. Let me know if you'd prefer me to handle it or create a separate PR instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants