Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): Add a ValueCodec for Uint complex type #24070

Merged
merged 8 commits into from
Mar 24, 2025

Conversation

hoangdv2429
Copy link
Contributor

Description

Closes: #23780
Backport


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@hoangdv2429 hoangdv2429 requested a review from a team as a code owner March 20, 2025 07:53
Copy link
Collaborator

@aljo242 aljo242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these were untested - we should test if possible

@hoangdv2429
Copy link
Contributor Author

Looks like these were untested - we should test if possible

I think we do have tests in codec_test.go ..?

@aljo242
Copy link
Collaborator

aljo242 commented Mar 21, 2025

But it doesnt look like this new type is tested right?

@hoangdv2429
Copy link
Contributor Author

But it doesnt look like this new type is tested right?

codec_test.go already tested Encode, Decode, EncodeJSON, DecodeJSON and do empty check for Stringify and ValueType. I added the other 2 testcases for exact value.

@aljo242 aljo242 merged commit f0bc9af into cosmos:release/v0.53.x Mar 24, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants