Allow the compression level to be set in zip files #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Python 3.7 the Python zipfile module has allowed setting the default compression level in zipfiles using the `compresslevel` argument.
conda-bot
added
the
cla-signed
|
A basic comparison of compression size vs time: conda create -p ./to_pack python=3.11
conda-pack -p ./to_pack -o test_0.zip --compress-level=0 --force
conda-pack -p ./to_pack -o test_4.zip --compress-level=4 --force
conda-pack -p ./to_pack -o test_9.zip --compress-level=9 --force
conda-pack -p ./to_pack -o test_default.zip --force
|
jezdez
reviewed
Feb 10, 2023
| @@ -75,8 +75,7 @@ def build_parser(): | |||
| default=4, | |||
| help=("The compression level to use, from 0 to 9. " | |||
| "Higher numbers decrease output file size at " | |||
| "the expense of compression time. Ignored for " | |||
| "``format='zip'``. Default is 4.")) | |||
| "the expense of compression time. Default is 4.")) | |||
There was a problem hiding this comment.
Let's mention that 9 is the highest value accepted for zip files using zlib.
|
I need to think a bit about a strategy for testing this. The compression level is not recorded in the resulting zip file so there is no way to validate what level was used. Comparing the sizes of different level could work as a heuristic but there is no guarantee that higher compression level will reduce the file size. |
jezdez
approved these changes
Jun 6, 2023
jezdez
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since Python 3.7 the Python zipfile module has allowed setting the
default compression level in zipfiles using the
compresslevelargument.
Pass the compression level specified on the command line to the ZipFile class.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?