Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovations and require Python >=3.7 #206

Merged
merged 4 commits into from
Jan 24, 2022
Merged

Renovations and require Python >=3.7 #206

merged 4 commits into from
Jan 24, 2022

Conversation

dbast
Copy link
Member

@dbast dbast commented Jan 20, 2022

Only renovations and disabling Python 2.7/3.6 support (no functional code changes)

  • Switch from flake8 only to pre-commit (including flake8 and more checks): Found and fixed a broken shebang.
  • Apply and check import orders with isort
  • remove Python 2.7+3.6 support due to EOL (tests already run with Python 3.7 as lower and 3.10 as upper bound)
  • Upgrade code to py37-plus with pyupgrade: Python2 conditionals get removed and string handling is consistently converted to f-string syntax.

This is all done via atomic commits, where each one runs green on CI (please merge without squash).

@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 20, 2022
@dbast dbast changed the title Renovations Renovations and disabling Python 2.7/3.6 support Jan 21, 2022
@dbast dbast marked this pull request as ready for review January 24, 2022 08:46
@dbast dbast changed the title Renovations and disabling Python 2.7/3.6 support Renovations and require Python >=3.7 Jan 24, 2022
@dbast dbast requested review from xhochy and a team January 24, 2022 10:59
@xhochy xhochy merged commit 40b891d into master Jan 24, 2022
@xhochy xhochy deleted the renovate branch January 24, 2022 11:34
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jan 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants