Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Solver for Laplace's equation for electric potential #2

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

sbryngelson
Copy link
Member

Feature for for electrodrops

@sbryngelson sbryngelson added the enhancement New feature or request label Jul 29, 2023
@suzanmanasreh suzanmanasreh mentioned this pull request Jun 10, 2024
3 tasks
@sbryngelson
Copy link
Member Author

Hi @mfirouzn you are attempting to make a PR into the master branch of this code. This is fine but you are removing details about the other parts of the code (which include capabilities for blood cells, for example). You are also making the main citation of the code repo our EHD paper. Instead, that citation should go in the readme. The main citation for this code goes back 10 years.

@mfirouzn
Copy link

mfirouzn commented Feb 3, 2025

Hey @sbryngelson,
Sorry about that—this was a mistake on my part. I didn’t mean to change anything on this repo.
Merging this code with the RBC version would take quite a bit of effort. I was trying to set up a repo for the active drop project but wasn’t sure of the best way to do it without creating multiple forks of the original project. For now, I just put it in a private repo.
I thought I was working on the README file for that private repo, but I accidentally touched this repo instead. My bad!

@mfirouzn
Copy link

mfirouzn commented Feb 3, 2025

I changed the readme file back to its original version. Let me know if I missed anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants