Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core]: Refactor Spinner/MSG Function (support now alpine / performance / handling) #3436

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

MickLesk
Copy link
Member

✍️ Description

  • Support now fully alpine variant (update / install)
  • better handling of msg_info - msg_ok
  • better performance (no shadow processes)
  • alpine update now work fine with msg_* blocks

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

@MickLesk MickLesk requested a review from a team as a code owner March 27, 2025 09:41
@github-actions github-actions bot added core high risk A change that can affect many scripts maintenance Code maintenance or general upkeep of the project labels Mar 27, 2025
@michelroegl-brunner michelroegl-brunner merged commit 022472a into main Mar 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core high risk A change that can affect many scripts maintenance Code maintenance or general upkeep of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants