Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: ErsatzTV Script #3365

Merged
merged 4 commits into from
Mar 24, 2025
Merged

Refactor: ErsatzTV Script #3365

merged 4 commits into from
Mar 24, 2025

Conversation

MickLesk
Copy link
Member

✍️ Description

Use now the latest ffmpeg (web-ui give an hint, use 6.1 but 7.0 work like charme)
general refactoring with update function

🔗 Related PR / Issue

Link: #3339

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

@MickLesk MickLesk requested a review from a team as a code owner March 24, 2025 08:53
@github-actions github-actions bot added refactor update script A change that updates a script labels Mar 24, 2025
@MickLesk MickLesk changed the title Redesign ersatz tv Redesign/Refactor: ErsatzTV Script Mar 24, 2025
@community-scripts community-scripts deleted a comment from github-actions bot Mar 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

⚠️ The script ct/ersatztv.sh failed with the following message:

/dev/dri/renderD128 is not a device

@MickLesk MickLesk changed the title Redesign/Refactor: ErsatzTV Script Refactor: ErsatzTV Script Mar 24, 2025
michelroegl-brunner
michelroegl-brunner approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@michelroegl-brunner michelroegl-brunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this makes @tremor021 PR not needed anymore?

@MickLesk
Copy link
Member Author

yep its an full refactor

@MickLesk MickLesk merged commit e2e6ad5 into main Mar 24, 2025
4 checks passed
@MickLesk MickLesk deleted the redesign_ersatzTV branch March 24, 2025 18:09
clouserw
clouserw reviewed Mar 28, 2025
View reviewed changes
ct/ersatztv.sh
temp_file=$(mktemp)
wget -qO- https://github.com/ErsatzTV/ErsatzTV/releases/download/${RELEASE}/ErsatzTV-${RELEASE}-linux-x64.tar.gz -O "$temp_file"
tar -xzf "$temp_file"
mv /opt/ErsatzTV-${RELEASE}-linux-x64 /opt/ErsatzTV
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change because it assumes a person is in /opt when they run update. I'd suggest removing "/opt/" from the source so it will use the CWD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clouserw clouserw clouserw left review comments

@michelroegl-brunner michelroegl-brunner michelroegl-brunner approved these changes

@CrazyWolf13 CrazyWolf13 CrazyWolf13 approved these changes

Assignees
No one assigned
Labels
refactor update script A change that updates a script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MickLesk @clouserw @michelroegl-brunner @CrazyWolf13