Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revealjs: Fix update process #3341

Merged
merged 1 commit into from
Mar 22, 2025
Merged

Conversation

tremor021
Copy link
Member

✍️ Description

gulpfile.js we are currently backing up is incompatible with new version. We're not backing it up any more since its a simple sed change anyway.

🔗 Related PR / Issue

Link: #3340

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines

📋 Additional Information (optional)

@tremor021 tremor021 self-assigned this Mar 22, 2025
@tremor021 tremor021 requested a review from a team as a code owner March 22, 2025 20:30
@tremor021 tremor021 linked an issue Mar 22, 2025 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added the update script A change that updates a script label Mar 22, 2025
@MickLesk MickLesk merged commit d68c466 into community-scripts:main Mar 22, 2025
3 checks passed
@tremor021 tremor021 deleted the revealjs branch March 22, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RevealJS Update fails - Cannot find module 'gulp-tap'
3 participants