Color code the RouteList with some sort of "sunlight" color temperature, based on latitude & longitude and time of day #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice idea! Can you |
yuzisee
added a commit
to yuzisee/new-connect
that referenced
this pull request
Mar 3, 2025
"error: lockfile had changes, but lockfile is frozen"
yuzisee
force-pushed
the
dev-sunlight-colors
branch
from
98f21ca to
7d3ce0b
Compare
yuzisee
commented
Mar 3, 2025
yuzisee
added a commit
to yuzisee/new-connect
that referenced
this pull request
Mar 3, 2025
yuzisee
force-pushed
the
dev-sunlight-colors
branch
from
3fb7943 to
531f1d2
Compare
yuzisee
added a commit
to yuzisee/new-connect
that referenced
this pull request
Mar 3, 2025
deployed preview: https://202.connect-d5y.pages.devWelcome to connect! Make sure to:
Mobile
Desktop
|
yuzisee
commented
Mar 3, 2025
|
I would probably try changing the background colour of the cards, or adding a gradient to them, instead of just a border |
yuzisee
added a commit
to yuzisee/new-connect
that referenced
this pull request
Mar 5, 2025
Cool. Something like a750f3a maybe? 
|
|
looks cool! |
…which has the benefit that you can quickly see which were at daytime vs. nighttime based purely on the color themes of the frames. Without them you have to manually read every time of day line and it's a slower (and more effort) to read line-by-line to scroll down to a certain moment you had in mind Loading all these frames increases server load though, so in the new connect we may as well color code the background of each <a> with some sort of "sunlight" color temperature based on latitude & longitude and time of day instead. Original discussion here: https://discord.com/channels/469524606043160576/1244366765983535145/1345905314989342730 --- Light Comes From the Sky * https://medium.com/@erikdkennedy/7-rules-for-creating-gorgeous-ui-part-1-559d4e805cda * https://learnui.design/blog/7-rules-for-creating-gorgeous-ui-part-2.html
"error: lockfile had changes, but lockfile is frozen"
yuzisee
force-pushed
the
dev-sunlight-colors
branch
from
9fae18e to
07280de
Compare
|
Rebased onto latest master. @incognitojam let me know if there's anything else you'd like to see — Otherwise I'll leave this pull request as-is and you can do whatever you'd like with it. Cheers! (Or, if you'd like me to continue rebasing periodically until a decision is made, I can do that too; just let me know) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old connect.comma.ai shows the frames of video in the RouteList, which has the benefit that you can quickly see which were at daytime vs. nighttime based purely on the color themes of the frames. Showing all these frames makes loading too slow, so in the new connect this feature has been removed.
However, we still could at least color code each with some sort of "sunlight" color temperature based on latitude & longitude and time of day instead. That way, if you're trying to quickly scroll down to a certain moment you had in mind you can do it easily without slowly (and carefully) reading every time of day line-by-line.
Original discussion here: https://discord.com/channels/469524606043160576/1244366765983535145/1345905314989342730