Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ClearableLinker to recover from exceptions in Scala.js #1891

Merged
merged 2 commits into from
Jun 3, 2022

Conversation

lolgab
Copy link
Member

@lolgab lolgab commented Jun 3, 2022

No description provided.

@lolgab lolgab force-pushed the use-clearable-linker-scala-js branch from 103341d to fc65b41 Compare June 3, 2022 08:20
@lolgab lolgab marked this pull request as ready for review June 3, 2022 09:12
@lolgab lolgab requested review from lefou and lihaoyi June 3, 2022 09:13
@lolgab
Copy link
Member Author

lolgab commented Jun 3, 2022

@lefou CI is green. I stopped the Push checks since I pushed to origin by mistake instead of pushing to lolgab and didn't want to waste CI resources. All the Pull Request checks passed.
It is ready to merge from my side.

Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@lefou lefou merged commit eb6204d into main Jun 3, 2022
@lefou lefou deleted the use-clearable-linker-scala-js branch June 3, 2022 11:06
@lefou lefou added this to the after 0.10.4 milestone Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants