This repository was archived by the owner on May 19, 2022. It is now read-only.
Fix issue #95 #115
Open
Fix issue #95 #115
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 24, 2017 14:11
The problem is that the BSD version of `grep` has the peculiar behavior of
printing the string `(standard input)` on matches that occur on standard
input. This results in that literal string being included with every
match. Which disturbs the matching logic of `fasd`.
For example, the code below is affected:
```
[ -${typ:-e} "${line%%\|*}" ] && printf %s\\n "$line"
```
On a match, the `${line%%\|*}` line will contain `(standard
input):some_filename`. As a result, the file test operator (`-e`, `-d`,
etc) will not succeed and so the query will not return anything :(
This fix makes the name of the `grep` utility a configurable parameter.
This would allow somebody to install the GNU version of grep and define
`_FASD_GREP=PATH_TO_GNU_GREP` inside `.fasdrc`.
Problem with running on a mac #95
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests includes a typo fix and a solution for issue 95.