Dont re-raise InvalidDefinitions when encountering invalid frames during startup #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can potentially lead to problems/dataloss because the queue would not be created when loading definitions. If the queue is later re-declared, that could delete any existing messages. |
|
Most pressing problems is fixed by #1019 , but maybe we still want to implement something similar to this, because similar errors can occur in the future, and maybe we don't want LavinMQ to be able to start if some x-argument is missing/bad in definitions. If we choose to do this, we probably should show the error in GUI somewhere though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Removes the re-raise of
InvalidDefinitionson errors when loading definitions on startup, so that LavinMQ can startup even if there are errors when loading definitions. Any queues/exchanges with invalid frames will not be created, and there will be logs detailing why.Fixes #1014
HOW can this pull request be tested?
Create a queue with
x-message-deduplication = true(and nox-cache-size) in v2.1.0, it will fail if upgraded to v2.2.0, but should work with this change.