feat(extra-natives-rdr3): add GET_CURRENT_SCREEN_RESOLUTION for RedM
#3159
+46
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
invalid
outsider31000
force-pushed
the
screen-resolution
branch
3 times, most recently
from
f2fd3d2 to
f3ca611
Compare
github-actions
bot
added
triage
outsider31000
force-pushed
the
screen-resolution
branch
from
f3ca611 to
2164686
Compare
github-actions
bot
added
invalid
outsider31000
force-pushed
the
screen-resolution
branch
3 times, most recently
from
6ee524a to
a614925
Compare
github-actions
bot
added
triage
outsider31000
force-pushed
the
screen-resolution
branch
from
a614925 to
9b47629
Compare
prikolium-cfx
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Adds a new native to get the screen resolution, since RDR3natives is hardcoded, In RedM there is not a way to get the current screen resolution
big thanks to @Ktos93 for helping out.
How is this PR achieving the goal
by adding this native users can use it to get the correct and current screen resolution
This PR applies to the following area(s)
RedM
Successfully tested on
I'd like to also mention that I've tested switching between resolutions and it gives me the right result.
Game builds: ..
tested on 1491 and 1436
1355 the build it self is broken so I couldn't test on that one.
Platforms: Windows, Linux
windows
Checklist
Fixes issues