fix: windows: AltGr maps to LEFT_CTRL+RIGHT_ALT #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
force-pushed
the
windows/respect-altgr
branch
from
e106519 to
ee083a3
Compare
On Windows, some keyboard layouts have an AltGr button that's similar to the Mac options button and can be used to send characters. This PR respects the AltGr button and treat its characters as bubbletea key runes. Fixes: #1126
caarlos0
approved these changes
Oct 28, 2024
| @@ -334,7 +338,7 @@ func keyType(e coninput.KeyEventRecord) KeyType { | |||
| case '\x1a': | |||
| return KeyCtrlZ | |||
| case '\x1b': | |||
| return KeyCtrlCloseBracket | |||
| return KeyCtrlOpenBracket // KeyEscape | |||
There was a problem hiding this comment.
They're the same value both are \x1b
caarlos0
approved these changes
Feb 6, 2025
meowgorithm
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, some keyboard layouts have an AltGr button that's similar to the Mac options button and can be used to send characters. This PR respects the AltGr button and treat its characters as bubbletea key runes.
Fixes: #1126