feat(viewport): horizontal scroll with mouse wheel #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for the events of a horizontal mouse wheel and when holding shift while using the regular mouse wheel now scrolls the screen left and right.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for horizontal mouse wheel scrolling in the viewport module. The changes introduce new handling for horizontal scrolling events by using the existing horizontalStep value and by enabling horizontal scrolling when holding the shift key with the regular mouse wheel.
caarlos0
approved these changes
Mar 28, 2025
|
Thanks for taking a look! |
|
cool! thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the events of a horizontal mouse wheel and when holding shift while using the regular mouse wheel now scrolls the screen left and right.
I chose to use the
horizontalStepvalue instead of theMouseWheelDeltabecause it is already used for horizontal movement.