Use full git email for github-actions bot #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5fac6ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Andarist
reviewed
Mar 10, 2025
| @@ -9,7 +9,7 @@ export const setupUser = async () => { | |||
| await exec("git", [ | |||
| "config", | |||
| "user.email", | |||
| `"github-actions[bot]@users.noreply.github.com"`, | |||
| `"41898282+github-actions[bot]@users.noreply.github.com"`, | |||
There was a problem hiding this comment.
I guess it's its ID... so it should be stable 🤷♂️
There was a problem hiding this comment.
Yeah I think it should. The earliest mention I found was from 2020, and the checkout action also mentions it. So likely safe enough.
Andarist
approved these changes
Mar 10, 2025
Merged
calvinjd
pushed a commit
to calvinjd/changesets-action
that referenced
this pull request
Mar 10, 2025
* Use full git email for github-actions bot * Create fluffy-clocks-knock.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The full git email for
github-actions[bot]has the initial41898282+part.Initially I thought fixing this would make GitHub no longer generate co-author descriptions by default, because the PR author and the commit author are already the same bot. Example. But after fixing the email myself and releasing again, the co-author is still there. Example
So while this doesn't quite fix anything, and I could also remove the co-author manually if I wanted, I thought it's still beneficial to update this to be consistent and maybe one day GitHub might fix this.
NOTE: The original full email can be retrieved by prepending
.patchto the commit URLs above. Example