Update ListXattrs to check for xattrs in memory and on disk #1586
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1570 allowed xattrs to work in QEMU but subsequently broke xattrs for runners that use bind mounts (i.e., Bubblewrap and Docker).
This PR addresses this by checking for xattrs both in-memory and on-disk to ensure that we retrieve every possible xattr.
I built
fping
with Bubblewrap, Docker, and QEMU with this change and it seemed to work. I had some Melange changes but I don't think they're necessary and I ended up removing them.Bubblewrap:
Docker:
QEMU:
I also checked one of the problematic builds we were seeing: