Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of conversion to java.time classes #593

Merged
merged 2 commits into from
Mar 23, 2025
Merged

Conversation

Chaosfirebolt
Copy link
Contributor

- resolves issue cbeust#493
- unit tests
- supported - Instant, LocalDate, LocalDateTime, LocalTime, OffsetDateTime, OffsetTime, ZonedDateTime
- register converters in default factory
Copy link
Collaborator

@mkarg mkarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! This is awesome!

Can you please check the issue I commented?

- converters support by default only ISO formats
- change supported formats collection to set
- simplify parse attempt in JavaTimeConverter
@Chaosfirebolt Chaosfirebolt requested a review from mkarg March 23, 2025 11:35
@mkarg mkarg merged commit ea04ce6 into cbeust:master Mar 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants