Add a test for the already-fixed CrossAxisAlignment layout bug #2363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
changed the base branch from
jwilson.1003.same_strategy
to
jwilson.1003.flex_nested
swankjesse
changed the title
swankjesse
commented
Oct 4, 2024
There was a problem hiding this comment.
Still need to figure out why our Lazylist tests aren’t working for these.
JakeWharton
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
I guess this is broken since it's not filling the column. Need an issue filed?
There was a problem hiding this comment.
Good call! #2367
swankjesse
force-pushed
the
jwilson.1003.flex_nested
branch
from
91e8f4c to
703fe99
Compare
swankjesse
force-pushed
the
jwilson.1004.cross_axis_alignment_bug
branch
from
70652ac to
4748a4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And the row-child-wrapping bug
Closes: #2093
Closes: #2011