Work around a bug where LazyList.placeholders crash on remove #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately this requires a change to generated code. But it only changes the behavior when talking to older apps that don't have the proper fix to the memory leak.
swankjesse
force-pushed
the
jwilson.0409.lazy_list_placeholders_broken
branch
from
c67cf58 to
05d30ad
Compare
JakeWharton
approved these changes
Apr 9, 2024
swankjesse
pushed a commit
that referenced
this pull request
Apr 16, 2024
swankjesse
pushed a commit
that referenced
this pull request
Apr 16, 2024
swankjesse
pushed a commit
that referenced
this pull request
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately this requires a change to generated code. But it only changes the behavior when talking to older apps that don't have the proper fix to the memory leak.
CHANGELOG.md's "Unreleased" section has been updated, if applicable.