Add support for snapshots for android multiplatform #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-powell
requested review from
nak5ive,
BrianGardnerAtl,
gamepro65 and
jrodbx
geoff-powell
force-pushed
the
gpowell/multiplatform-snapshots
branch
2 times, most recently
from
e6defe1 to
f71a4cb
Compare
jrodbx
reviewed
Oct 22, 2024
| @@ -89,7 +90,30 @@ public class PaparazziPlugin @Inject constructor( | |||
| project.addTestDependency() | |||
| val layoutlibNativeRuntimeFileCollection = project.setupLayoutlibRuntimeDependency() | |||
| val layoutlibResourcesFileCollection = project.setupLayoutlibResourcesDependency() | |||
| val snapshotOutputDir = project.layout.projectDirectory.dir("src/test/snapshots") | |||
| val testSourceSetProvider = project.objects.directoryProperty() | |||
| testSourceSetProvider.set(project.layout.projectDirectory.dir("src/test")) | |||
There was a problem hiding this comment.
there should be a way to query Gradle for the test source set, vs hardcoding them
Comment on lines
8
to
16
| androidTarget { | ||
| publishLibraryVariants('release') | ||
| } | ||
|
|
||
| sourceSets { | ||
| commonTest.dependencies { | ||
|
|
||
| } | ||
| commonMain.dependencies { | ||
|
|
||
| } | ||
| androidMain { | ||
| dependencies { | ||
| implementation 'androidx.appcompat:appcompat:1.7.0' | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| androidTarget { | |
| publishLibraryVariants('release') | |
| } | |
| sourceSets { | |
| commonTest.dependencies { | |
| } | |
| commonMain.dependencies { | |
| } | |
| androidMain { | |
| dependencies { | |
| implementation 'androidx.appcompat:appcompat:1.7.0' | |
| } | |
| } | |
| } | |
| androidTarget() |
none of this KMP boilerplate affects the test purpose
Comment on lines
45
to
47
| dependencies { | ||
| testImplementation libs.junit | ||
| } |
There was a problem hiding this comment.
Suggested change
| dependencies { | |
| testImplementation libs.junit | |
| } |
|
|
||
| @Test | ||
| fun test() { | ||
| paparazzi.snapshot(HelloPaparazzi(paparazzi.context)) |
There was a problem hiding this comment.
Suggested change
| paparazzi.snapshot(HelloPaparazzi(paparazzi.context)) | |
| paparazzi.snapshot(TextView(paparazzi.context).apply { text = "Hello Paparazzi!" }) |
| kotlinOptions { | ||
| jvmTarget = libs.versions.javaTarget.get() | ||
| } | ||
| } |
There was a problem hiding this comment.
interesting that KMP requires this, but the other projects don't!
| project.plugins.withId("org.jetbrains.kotlin.multiplatform") { | ||
| val kmpExtension = project.extensions.getByType(KotlinMultiplatformExtension::class.java) | ||
| kmpExtension.sourceSets.all { sourceSet -> | ||
| if (sourceSet.name == "androidUnitTest" || sourceSet.name == "androidTest") { |
There was a problem hiding this comment.
similar, is there a way for the plugin to tell us test source sets?
There was a problem hiding this comment.
while i agree that hardcoded values aren't great, this is still an improvement over our current setup which breaks the directory structure for multiplatform projects.
geoff-powell
force-pushed
the
gpowell/multiplatform-snapshots
branch
from
f71a4cb to
b4d6694
Compare
|
hey, any updates on this? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds source set support for Android Multiplatform projects.
Closes #595.