remove function pointer comparisons #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwrensha
force-pushed
the
function-pointer-cmp
branch
from
d05be06 to
68d3f7a
Compare
The impl of PartialEq for RawBrandedStructSchema depended on comparing function pointers. The latest rustc emits a warning indicating that such comparison is not reliable. So this diff updates RawBrandedStructSchema to use a slower but more reliable method to check for equality. This diff also makes some assertions less strict in DynamicStruct and DynamicList, because the previous strictness is now more expensive.
dwrensha
force-pushed
the
function-pointer-cmp
branch
from
68d3f7a to
2361905
Compare
zirconium-n
reviewed
Mar 7, 2025
| // > since their addresses are not guaranteed to be unique | ||
|
|
||
| if core::ptr::eq(self.generic, other.generic) { | ||
| return false; |
There was a problem hiding this comment.
Good catch! It should be negated, like this:
if !core::ptr::eq(self.generic, other.generic) {
return false;
}See #550.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.