Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add types for req.req and req.res #415

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

schwma
Copy link
Member

@schwma schwma commented Feb 27, 2025

part of cap/issues/17887
documented in cap-js/docs#1603

@daogrady daogrady marked this pull request as ready for review March 6, 2025 06:49
@daogrady daogrady marked this pull request as draft March 6, 2025 06:50
@daogrady
Copy link
Contributor

daogrady commented Mar 6, 2025

From what I can see, this looks pretty much done. Is it still a draft or ready for review?

@schwma
Copy link
Member Author

schwma commented Mar 6, 2025

The PR is still a draft since the API isn't final yet and might still change. See cap-js/docs#1603 (comment) for slightly more details.

@daogrady
Copy link
Contributor

daogrady commented Mar 6, 2025

I see! Just wanted to make sure you were not waiting for my approval. 🙂

@schwma
Copy link
Member Author

schwma commented Mar 6, 2025

Thank you! 🙂 I'll let you know as soon as I know more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants