feat: support current_utctimestamp #865
Conversation
This reverts commit 875e376.
johannes-vogel
requested review from
danjoa,
stewsk,
BobdenOs,
patricebender,
sjvans and
David-Kunz
as code owners
| @@ -0,0 +1,50 @@ | |||
| const cds = require('../../test/cds') | |||
There was a problem hiding this comment.
Should we add this function definition into the other databases?
Then the test can be move here:
cds-dbs/test/compliance/functions.test.js
Lines 339 to 348 in 45bcdcf
There was a problem hiding this comment.
I initially started there but the other databases don't support the argument, I could also split: noargs in compliance and args in hana native section.
There was a problem hiding this comment.
#909 but I don't like the different behavior on the dbs
There was a problem hiding this comment.
It is a good finding that the databases have different response formats. The purpose of the cal-functions is to define them in a way that they response in the correct format. Most likely adding a cast or element to the original func can apply the correct output converter for each database.
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 1.16.0</summary> ## [1.16.0](db-service-v1.15.1...db-service-v1.16.0) (2024-11-25) ### Changed * single column in `search` function is also treated as CQN `list` ([#898](#898)) ([f6593e6](f6593e6)) ### Fixed * foreignKeys aspect on association may not be set ([#903](#903)) ([732a2f3](732a2f3)) * insert on uuid with default value ([#911](#911)) ([545e489](545e489)) * `session_context`, `current_date`, `current_time` and `current_timestamp` are treated as SAP HANA functions and are callable in upper case ([#910](#910)) ([50ebd10](50ebd10)) * wrap values in array if it is object, so it can be spreaded ([#882](#882)) ([11f3e8b](11f3e8b)) </details> <details><summary>hana: 1.5.0</summary> ## [1.5.0](hana-v1.4.1...hana-v1.5.0) (2024-11-25) ### Added * config options for fuzzy search ([#898](#898)) ([f6593e6](f6593e6)) * support current_utctimestamp ([#865](#865)) ([aaf39ad](aaf39ad)) ### Fixed * `current_date`, `current_time`, `current_timestamp` and `current_utctimestamp` are SAP HANA functions and are callable in upper case ([#910](#910)) ([50ebd10](50ebd10)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Johannes Vogel <[email protected]>
works locally with SAP HANA Cloud but does not work with HXE