-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce key length for IE8 #4
Comments
Hey, so is this 2048 now, or have you reduced the key length to 1024/6h? Just curious because IE9 and Opera (both on VM) can fail too ;-) |
I'm still not terribly familiar with jwcrypto... @jrgm, do you know where key length is configured? |
Seems IE10 also cannot work with mockmyid.com. |
I think we need to get multiple key support into the |
One minor note for people who see this with IE10 - IE10 appears to try to fallback to a compatibility mode when the cpu has spun out of control for a while and then fails because "Error: 'JSON' is undefined". |
bah, wtf IE? :( |
@callahad I just got the long-running script error on IE8. Is this the same issue? If it is, I'm happy to help debug. IE throws this error after some number of consecutive JS commands have run without the UI thread getting a turn, so one fix is to run for (say) 100ms, then use setTimeout(0) to throw the remainder of the computation on the back of the stack, and continue the execution after the UI thread runs. |
@6a68 The quick fix is to generate a new, smaller key for mockmyid. At the time, it looked like multiple key support was imminent, and I didn't want to break folks relying on that key not changing. Guess it's time to make that happen regardless. |
Wait, this is related to size of client side generated keypairs. The signing keypairs should be irrelevant from a perf perspective. s/256/128/ in js. -- lloyd (thumb-typing) On Apr 19, 2013, at 7:38 PM, Dan Callahan [email protected] wrote:
|
@lloyd I'm doing all of the cert generation client side -- there's no backend to mockmyid. Current theory is that this is an issue with the domain's key size and type being a bit too much to handle for IE. |
Reducing key size to make mockmyid work seems like the wrong trade-off.
|
Agree. Was not proposing we change anything in persona. Just forgot there for a moment that user key length is completely under persona control. -- lloyd (thumb-typing) On Apr 19, 2013, at 8:38 PM, Ben Adida [email protected] wrote:
|
@benadida I'm not sure I follow? MockMyID is signing with an RS256 key right now. Switching to DS128 fixes it. Normally, these computations would be done server-side, so it's moot for "real" IdPs. |
@callahad I'm an idiot and thought this was a bug in the browserid repo. Don't mind me. |
@callahad @benadida I'd argue that a client-side crypto library should always use setTimeout/setImmediate to break up calculations to avoid the long-running script error; this is a fundamental limitation of working in the browser. Maybe I'll file my issue against jwcrypto? /cc @warner Nicholas Zakas has written a good series of articles on the subject of understanding and avoiding the long-running script error:
|
For sure, but it's tricky cause we use existing crypto libraries that are
|
Callahad reduced mockmyid domain key length to 1024/dsa and it resolved this. Patch forthcoming iirc. No changes to persona needed. Ben, in your defense, I was an idiot too. Idp can't affect user keypair length. Duh. -- lloyd (thumb-typing) On Apr 20, 2013, at 11:58 AM, Ben Adida [email protected] wrote:
|
Recommended is 1024 for certs with a 6 hour validity.
The text was updated successfully, but these errors were encountered: