Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sso_auth: make provider_*_okta_server optional #292

Merged
merged 2 commits into from
May 1, 2020
Merged

sso_auth: make provider_*_okta_server optional #292

merged 2 commits into from
May 1, 2020

Conversation

kjetijor
Copy link
Contributor

Problem

Quickstart (and testing in practice) seems to indicate that PROVIDER_*_OKTA_SERVER should be optional, if you wish to use the default okta authorization server.

If you are not using the default Okta authorization server you will also need to add PROVIDER_OKTAQUICKSTART_SERVER_ID= to the above file.

Solution

Make it optional!

Notes

Kjetil Joergensen added 2 commits April 29, 2020 17:18
The quickstart seems to indicate that this is optional
@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #292 into master will increase coverage by 0.06%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #292      +/-   ##
==========================================
+ Coverage   61.87%   61.94%   +0.06%     
==========================================
  Files          57       57              
  Lines        4640     4638       -2     
==========================================
+ Hits         2871     2873       +2     
+ Misses       1556     1553       -3     
+ Partials      213      212       -1     
Impacted Files Coverage Δ
internal/auth/configuration.go 47.41% <ø> (+0.44%) ⬆️
internal/auth/providers/okta.go 60.65% <80.00%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8f495b...db8e841. Read the comment docs.

Copy link
Contributor

@Jusshersmith Jusshersmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kjetijor,

Thank you contributing and fixing this!

@Jusshersmith Jusshersmith changed the title PROVIDER_*_OKTA_SERVER optional sso_auth: make provider_*_okta_server optional May 1, 2020
@Jusshersmith Jusshersmith merged commit 4f8f6e7 into buzzfeed:master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants