Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.1 is broken on Clojars #22

Closed
GentlemanHal opened this issue Aug 17, 2018 · 0 comments
Closed

v1.0.1 is broken on Clojars #22

GentlemanHal opened this issue Aug 17, 2018 · 0 comments
Labels

Comments

@GentlemanHal
Copy link
Member

GentlemanHal commented Aug 17, 2018

I think this is because the deploy step has built a new jar without any source.

We have a manual step between building / testing and deploying as we don't want to automatically push every commit to clojars. So we copy the built jar to the workspace and the idea was once the deploy step was triggered it would use that. This has worked correctly when creating the release on GitHub but the lein deploy step seems to have built a new jar. This new jar doesn't contain any source files as we didn't copy them to the workspace between steps!

GentlemanHal pushed a commit that referenced this issue Aug 20, 2018
I'll manually deploy the new version to Clojars
GentlemanHal pushed a commit that referenced this issue Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant