Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-346] Add getGoogleProjects and getGoogleProjectById APIs #3229

Merged
merged 43 commits into from
Mar 28, 2025

Conversation

kevinmarete
Copy link
Contributor

@kevinmarete kevinmarete commented Mar 22, 2025

Ticket: https://broadworkbench.atlassian.net/browse/CORE-346

This PR adds two endpoints to manage Google projects:

  • GET /googleProjects Lists Google projects the user can access. It also supports optional filtering by billing project.
  • GET /googleProjects/{googleProjectId} Retrieves a Google project if accessible.

Notes:


  • Includes error handling for missing or unauthorized projects.
  • Tests cover both endpoints and edge cases.
  • Added read action to sam to support permissions check

PR checklist

  • Include the JIRA issue number in the PR description and title
  • Make sure Swagger is updated if API changes
    • ...and Orchestration's Swagger too!
  • If you changed anything in model/, then you should publish a new official rawls-model and perform the corresponding dependency updates as specified in the README:
    • in the automation subdirectory
    • in workbench-libs
    • in firecloud-orchestration
  • Get two thumbsworth of PR review
  • Verify all tests go green, including CI tests
  • Squash commits and merge to develop (branches are automatically deleted after merging)
  • Inform other teams of any substantial changes via Slack and/or email

@kevinmarete kevinmarete self-assigned this Mar 22, 2025
@kevinmarete kevinmarete requested a review from a team as a code owner March 22, 2025 19:07
@kevinmarete kevinmarete requested review from dvoet, davidangb, calypsomatic and Copilot and removed request for a team, dvoet and davidangb March 22, 2025 19:07
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (13)
  • core/src/main/resources/swagger/api-docs.yaml: Language not supported
  • core/src/main/scala/org/broadinstitute/dsde/rawls/dataaccess/slick/GoogleProjectRegistrationComponent.scala: Language not supported
  • core/src/main/scala/org/broadinstitute/dsde/rawls/googleProject/GoogleProjectRegistrationRepository.scala: Language not supported
  • core/src/main/scala/org/broadinstitute/dsde/rawls/googleProject/GoogleProjectRegistrationService.scala: Language not supported
  • core/src/main/scala/org/broadinstitute/dsde/rawls/model/SamModel.scala: Language not supported
  • core/src/main/scala/org/broadinstitute/dsde/rawls/webservice/GoogleProjectRegistrationApiService.scala: Language not supported
  • core/src/test/scala/org/broadinstitute/dsde/rawls/dataaccess/slick/GoogleProjectRegistrationComponentSpec.scala: Language not supported
  • core/src/test/scala/org/broadinstitute/dsde/rawls/googleProject/GoogleProjectRegistrationRepositorySpec.scala: Language not supported
  • core/src/test/scala/org/broadinstitute/dsde/rawls/googleProject/GoogleProjectRegistrationServiceSpec.scala: Language not supported
  • core/src/test/scala/org/broadinstitute/dsde/rawls/model/SamModelSpec.scala: Language not supported
  • core/src/test/scala/org/broadinstitute/dsde/rawls/webservice/GoogleProjectRegistrationApiServiceSpec.scala: Language not supported
  • model/src/main/scala/org/broadinstitute/dsde/rawls/model/GoogleProjectRegistrationModel.scala: Language not supported
  • model/src/test/scala/org/broadinstitute/dsde/rawls/model/GoogleProjectRegistrationModelSpec.scala: Language not supported

@kevinmarete kevinmarete requested review from marctalbott and dvoet and removed request for calypsomatic and marctalbott March 22, 2025 19:08
@kevinmarete kevinmarete requested a review from davidangb March 27, 2025 04:31
@kevinmarete kevinmarete requested review from davidangb and dvoet March 27, 2025 23:39
Copy link
Contributor

@dvoet dvoet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor change then 👍

Copy link
Contributor

@davidangb davidangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also have 1 minor change then 👍

@kevinmarete kevinmarete requested a review from davidangb March 28, 2025 14:26
@kevinmarete kevinmarete merged commit 822aabe into develop Mar 28, 2025
29 checks passed
@kevinmarete kevinmarete deleted the km_CORE-346_google_project_list_apis branch March 28, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants