-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE-346] Add getGoogleProjects and getGoogleProjectById APIs #3229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (13)
- core/src/main/resources/swagger/api-docs.yaml: Language not supported
- core/src/main/scala/org/broadinstitute/dsde/rawls/dataaccess/slick/GoogleProjectRegistrationComponent.scala: Language not supported
- core/src/main/scala/org/broadinstitute/dsde/rawls/googleProject/GoogleProjectRegistrationRepository.scala: Language not supported
- core/src/main/scala/org/broadinstitute/dsde/rawls/googleProject/GoogleProjectRegistrationService.scala: Language not supported
- core/src/main/scala/org/broadinstitute/dsde/rawls/model/SamModel.scala: Language not supported
- core/src/main/scala/org/broadinstitute/dsde/rawls/webservice/GoogleProjectRegistrationApiService.scala: Language not supported
- core/src/test/scala/org/broadinstitute/dsde/rawls/dataaccess/slick/GoogleProjectRegistrationComponentSpec.scala: Language not supported
- core/src/test/scala/org/broadinstitute/dsde/rawls/googleProject/GoogleProjectRegistrationRepositorySpec.scala: Language not supported
- core/src/test/scala/org/broadinstitute/dsde/rawls/googleProject/GoogleProjectRegistrationServiceSpec.scala: Language not supported
- core/src/test/scala/org/broadinstitute/dsde/rawls/model/SamModelSpec.scala: Language not supported
- core/src/test/scala/org/broadinstitute/dsde/rawls/webservice/GoogleProjectRegistrationApiServiceSpec.scala: Language not supported
- model/src/main/scala/org/broadinstitute/dsde/rawls/model/GoogleProjectRegistrationModel.scala: Language not supported
- model/src/test/scala/org/broadinstitute/dsde/rawls/model/GoogleProjectRegistrationModelSpec.scala: Language not supported
...ain/scala/org/broadinstitute/dsde/rawls/webservice/GoogleProjectRegistrationApiService.scala
Outdated
Show resolved
Hide resolved
...ain/scala/org/broadinstitute/dsde/rawls/googleProject/GoogleProjectRegistrationService.scala
Outdated
Show resolved
Hide resolved
...ain/scala/org/broadinstitute/dsde/rawls/googleProject/GoogleProjectRegistrationService.scala
Show resolved
Hide resolved
.../org/broadinstitute/dsde/rawls/dataaccess/slick/GoogleProjectRegistrationComponentSpec.scala
Show resolved
Hide resolved
...la/org/broadinstitute/dsde/rawls/googleProject/GoogleProjectRegistrationRepositorySpec.scala
Outdated
Show resolved
Hide resolved
...la/org/broadinstitute/dsde/rawls/googleProject/GoogleProjectRegistrationRepositorySpec.scala
Outdated
Show resolved
Hide resolved
...la/org/broadinstitute/dsde/rawls/googleProject/GoogleProjectRegistrationRepositorySpec.scala
Outdated
Show resolved
Hide resolved
...la/org/broadinstitute/dsde/rawls/googleProject/GoogleProjectRegistrationRepositorySpec.scala
Outdated
Show resolved
Hide resolved
...cala/org/broadinstitute/dsde/rawls/dataaccess/slick/GoogleProjectRegistrationComponent.scala
Outdated
Show resolved
Hide resolved
...cala/org/broadinstitute/dsde/rawls/dataaccess/slick/GoogleProjectRegistrationComponent.scala
Outdated
Show resolved
Hide resolved
...ain/scala/org/broadinstitute/dsde/rawls/googleProject/GoogleProjectRegistrationService.scala
Outdated
Show resolved
Hide resolved
...ain/scala/org/broadinstitute/dsde/rawls/googleProject/GoogleProjectRegistrationService.scala
Outdated
Show resolved
Hide resolved
.../org/broadinstitute/dsde/rawls/dataaccess/slick/GoogleProjectRegistrationComponentSpec.scala
Outdated
Show resolved
Hide resolved
...scala/org/broadinstitute/dsde/rawls/googleProject/GoogleProjectRegistrationServiceSpec.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/org/broadinstitute/dsde/rawls/model/SamModelSpec.scala
Outdated
Show resolved
Hide resolved
...scala/org/broadinstitute/dsde/rawls/webservice/GoogleProjectRegistrationApiServiceSpec.scala
Outdated
Show resolved
Hide resolved
...scala/org/broadinstitute/dsde/rawls/webservice/GoogleProjectRegistrationApiServiceSpec.scala
Show resolved
Hide resolved
...scala/org/broadinstitute/dsde/rawls/webservice/GoogleProjectRegistrationApiServiceSpec.scala
Outdated
Show resolved
Hide resolved
…rtions to use matchers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 minor change then 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also have 1 minor change then 👍
Ticket: https://broadworkbench.atlassian.net/browse/CORE-346
This PR adds two endpoints to manage Google projects:
GET /googleProjects
Lists Google projects the user can access. It also supports optional filtering by billing project.GET /googleProjects/{googleProjectId}
Retrieves a Google project if accessible.Notes:
read
action to sam to support permissions checkPR checklist
model/
, then you should publish a new officialrawls-model
and perform the corresponding dependency updates as specified in the README: