-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds "Your Books" to the header and removed "Feed" #2201
Conversation
The instance icon is already a link to the feed, and I think it's weird not to have a quick link to your books, since books are important.
I’m wondering if the loss of discoverability (the icon is not obviously clickable), never mind accessibility (loss of a text label), is worth this. Wouldn’t it be preferable to simply have the currently static “Your Books” heading in the sidebar link to the books? |
Perhaps a more drastic change is needed. Most search bars in most websites, including those dedicated to reading, are in the right side of the screen. Moving it there alongside the profile pic and notifications would allow the feed, lists and rest of links together to the left. Leaving more room for more items and also making the logo more recognizable as yet another link to click on, since it's alongside the others |
I was thinking of the left sidebar area of the feed. As I write this, I realise this is only available from the feed, which tells me two things:
|
I'm not sure I agree about linking via the "Your Books" panel -- personally, I want to get to my books from other pages (like a book's page), and I'm concerned that adding another link to that section, which is already pretty complicated, would be visually confusing and not work well on smaller screens. Regarding moving the search bar -- I'm not opposed to that, but I wonder if that's a second step after changing the top bar links? It's a harder proposition than it might seem on the surface because of the responsive behavior of the top bar. On mobile, the top bar links are in a menu and the search bar is retained, which I think is good behavior. |
I see where you are coming from, hence my observation above that I, OTOH, prize obvious, no-brainer access to the home feed way and above ubiquitous access to my books. Now please note I am not saying my usage scenario somehow trumps yours, far from it; I’m just pointing out that it’s different and that the currently planned reshuffle is improving discoverability for one usage case at the expense of the discoverability for another (having to think about “How did I go to the home feed again? Ah yes, click on the logo in the corner, right.” instead of having a clearly labelled item in the bar where all other navigation items are is not neutral UX wise). The fact that either solution privileges one scenario over the other (and again, I am not saying mine is any more valid than yours!) suggests to me we should be looking for a different solution entirely, one that offers the best of both worlds. I am not sure what that could be. One thing that comes to mind is to keep “Home” in the current position, but to use a symbol for it instead of a word. That would alleviate spacing issues and a house icon for “Home” is a common idiom, which, combined with the position in the navigation bar, would make it more discoverable than a link behind the logo (accessibility issues are the same for both solutions, I think). Just putting this out there.
Just for the record, I was suggesting making the “Your Books” heading itself the link, not adding an element. However, in light of the previous discussion, I think we can drop this idea altogether. |
At the risk of over-complicating this, what if we made what appears in this menu configurable by the user? If space is a problem, we could limit it to three menu items you can "pin", but each user can choose from a list of options in the user settings. Of course, that doesn't resolve the question of what the default options would be, though I think from an onboarding point of view the current three (Feed, Lists, Discover) is probably correct. |
I re-read this thread and i think the general consensus is to merge this and also that in the future we could re-think the title bar in a bigger picture sense? Please comment if you strongly object to me merging this -- I'm trying to clean up old PRs, and this one keeps irking me in the UI. |
I haven't been using BookWyrm for long, and after reading all comments my humble suggestion would be: do keep the Feed header, remove the Discover one, make the instance icon a link to discovery. Rationale: when you're logged out, the home page shows "discovery entries". If, say, I'm logged out and visit https://lectura.social/about, then the top-left instance icon takes me back to a "discovery-like view". Perhaps having the icon do the same while logged in would make sense. Also the icon represents the whole instance, which seems a good fit for discovery content. Just a thought, sorry if it just adds noise to an almost-settled topic. |
@mouse-reeve I think you should merge this per your comment on August 7, and additional finessing can be discussed further if desired. |
Update tour to reflect changes in #2201
The instance icon is already a link to the feed, and I think it's weird not to have a quick link to your books, since books are important.
Before:

After:
