-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/over time limited #512
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request introduces the ability to sample over time and adds a new example to showcase this functionality. It also modifies the naming convention of the generated example notebooks to include the sample with repeats and over time parameters. Class diagram showing BenchRunCfg changesclassDiagram
class BenchRunCfg {
+int repeats
+int level
+bool over_time
}
note for BenchRunCfg "Added over_time parameter"
Flow diagram showing notebook generation processflowchart TD
A[Start] --> B[Generate title]
B --> C{sample_over_time?}
C -->|Yes| D[Add '_over_time' to title]
C -->|No| E[Keep title as is]
D --> F[Create notebook]
E --> F
F --> G[Write notebook to file]
G --> H[End]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @blooop - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding the generated notebook files under docs/reference/meta/ to .gitignore since they are build artifacts that can be regenerated.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Add support for sampling over time and reduce the number of float variables in the meta example.
New Features:
sample_over_time
parameter to enable sampling benchmarks over time.Tests:
sample_over_time
parameter and reduced the number of float variables.