-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/fix 1d line multi #480
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request refactors the 1D line plotting to support multiple result variables and adds a new example to demonstrate this functionality. The changes also include a fix to how the dataset is filtered before plotting. Sequence diagram for updated curve plotting processsequenceDiagram
participant C as Client
participant H as HoloviewResult
participant D as Dataset
C->>H: to_curve_ds(dataset, result_var)
H->>D: get data_vars
loop For each variable
alt Not a _std variable
H->>H: Create Curve for var
alt Has matching _std variable
H->>H: Create Spread for var
end
end
end
H-->>C: Return Overlay with curves and spreads
Class diagram showing changes to Example1D and new example classesclassDiagram
class Example1D {
+index: IntSweep
+output: ResultVar
+output2: ResultVar
+__call__(**kwargs)
}
note for Example1D "Added output2 ResultVar"
class DataSource {
-data: List
+call(index, repeat)
}
Example1D ..> DataSource : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @blooop - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
==========================================
+ Coverage 89.97% 90.07% +0.09%
==========================================
Files 65 66 +1
Lines 3483 3505 +22
==========================================
+ Hits 3134 3157 +23
+ Misses 349 348 -1 ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
Add support for multiple ResultVars in a single ParametrizedSweep and update plotting to handle them correctly.
New Features:
Tests: