✈️ export custom scripts #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitbrain
commented
Aug 26, 2023
| @@ -1,5 +1,6 @@ | |||
| ## An entity acts a container for properties and is used to represent | |||
| ## a category or an actual concept in any game. | |||
| @tool | |||
There was a problem hiding this comment.
It is critical that PandoraEntity (and all its custom scripts) are a tool script, as this needs to be accessible inside the editor. No clue if there is another way to solve this!
bitbrain
commented
Aug 26, 2023
| ## .tscn file and then dynamically look up the actual entity | ||
| ## at runtime by accessing Pandora's API. | ||
| @tool | ||
| class_name PandoraEntityProxy extends PandoraEntity |
There was a problem hiding this comment.
This class prevented us from exporting custom types. Instead, we are now relying on class lookup.
bitbrain
commented
Aug 26, 2023
|
|
||
|
|
||
| # ClassName -> Dictionary | ||
| var _global_class_cache = {} |
There was a problem hiding this comment.
We have to maintain a class cache so we can lookup class dependency structures. Only exporting custom types of type PandoraEntity should be eligible for selection.
bitbrain
commented
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44
Description
This pull request aims to allow for exporting custom scripts in scenes. As a consequence, this pull request removes the concept of a
PandoraEntityProxyas we have to store custom types directly.Open Issues
Itemshould only produce entries whereentity is Itemis true!)