🐛 do not rely on autoloads to avoid startup errors #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitbrain
commented
Jan 2, 2024
| @@ -2,6 +2,8 @@ | |||
| extends EditorDebuggerPlugin | |||
|
|
|||
| const DebuggerTab := preload("debugger_tab.gd") | |||
| const BeehaveUtils := preload("res://addons/beehave/utils/utils.gd") | |||
There was a problem hiding this comment.
This avoids issues at initial load in case the global class cache might not have initialized BeehaveUtils yet.
bitbrain
commented
Jan 2, 2024
| @@ -20,7 +20,7 @@ func _on_debug_message(message: String, data: Array) -> bool: | |||
|
|
|||
|
|
|||
| func _set_active_tree(tree_id: int) -> void: | |||
| var tree: BeehaveTree = _registered_trees.get(tree_id, null) | |||
| var tree = _registered_trees.get(tree_id, null) | |||
There was a problem hiding this comment.
Not ideal but removing BeehaveTree from here excludes this class from initial dependency lookups.
bitbrain
commented
Jan 2, 2024
|
|
||
| # required to avoid lifecycle issues on initial load | ||
| # due to loading order problems with autoloads | ||
| func _get_global_metrics() -> Node: |
There was a problem hiding this comment.
Autoloads will be added to the scene tree, so we can look them up dynamically. Unfortunately, referencing them directly may not work, as the global class cache may not have loaded them at the time this class here is parsed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request aims to solve some of the long standing issues with getting Beehave to work on first load.
Addressed issues
Note: can please people test this build of Beehave to verify if this indeed fixes startup errors?