Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a customizable tick rate to improve perf (closes #255). #258

Merged
merged 6 commits into from
Dec 4, 2023
Merged

Implement a customizable tick rate to improve perf (closes #255). #258

merged 6 commits into from
Dec 4, 2023

Conversation

lucasrafael98
Copy link
Contributor

@lucasrafael98 lucasrafael98 commented Dec 2, 2023

Description

Simple implementation to solve #255 and greatly improve performance. The default remains at 1 because changing it is likely to break scripts that e.g. make agents move every tick.

edit closes #255

@lucasrafael98
Copy link
Contributor Author

Minor mistake, I think this should fix it.

@bitbrain
Copy link
Owner

bitbrain commented Dec 3, 2023

Could you add unit tests for this?

@lucasrafael98
Copy link
Contributor Author

Done, let me know if these are cool or if you need more. I also added reports/ to .gitignore but if that breaks e.g. CI I can rebase it out.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm.. chmodded it to make it executable. Do you want to leave it non-executable?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind - my Github showed it as 'new empty file added'

Copy link
Owner

@bitbrain bitbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@bitbrain bitbrain merged commit 8228d42 into bitbrain:godot-4.x Dec 4, 2023
@lucasrafael98 lucasrafael98 deleted the variable-rate-tick branch December 4, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Variable rate tick()
2 participants